keith-turner commented on a change in pull request #1083: [WIP] POC for Command
module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357759156
##########
File path:
modules/command/src/main/java/org/apache/fluo/command/CommonCommand.java
##########
@@ -17,18 +17,12 @@
import com.beust.jcommander.Parameter;
-class CommonOpts extends ConfigOpts {
+abstract class CommonCommand extends ConfigCommand {
Review comment:
What do you think about the name AppCommand for this class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
