keith-turner commented on a change in pull request #1083: [WIP] POC for Command
module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357765541
##########
File path:
modules/command/src/main/java/org/apache/fluo/command/BaseCommand.java
##########
@@ -15,29 +15,14 @@
package org.apache.fluo.command;
-import com.beust.jcommander.JCommander;
import com.beust.jcommander.Parameter;
-import com.beust.jcommander.ParameterException;
-
-public class BaseOpts {
+public abstract class BaseCommand implements FluoCommand {
Review comment:
I like the options in the same class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
