ctubbsii commented on a change in pull request #316: Add support for ZooKeeper
3.5
URL: https://github.com/apache/fluo-muchos/pull/316#discussion_r372694734
##########
File path: lib/muchos/config/base.py
##########
@@ -182,6 +183,10 @@ def _verify_config(self, action):
if self.java_product_version() >= 11 and
StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) <=
StrictVersion("1.9.3"):
exit("ERROR - Java 11 is not supported with Accumulo version
'{0}'".format(self.version('accumulo')))
+ # validate and fail if we are using ZooKeeper 3.5.5 or greater and
Accumulo 1.9.x or less
+ if StrictVersion(self.version('zookeeper')) >=
StrictVersion("3.5.5") and
StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) <
StrictVersion("1.10.0"):
Review comment:
If it doesn't work with 1.9, I wouldn't expect it to work with 1.10
either... but perhaps that will be fixed before released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
