billierinaldi commented on a change in pull request #316: Add support for
ZooKeeper 3.5
URL: https://github.com/apache/fluo-muchos/pull/316#discussion_r373072195
##########
File path: lib/muchos/config/base.py
##########
@@ -182,6 +183,10 @@ def _verify_config(self, action):
if self.java_product_version() >= 11 and
StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) <=
StrictVersion("1.9.3"):
exit("ERROR - Java 11 is not supported with Accumulo version
'{0}'".format(self.version('accumulo')))
+ # validate and fail if we are using ZooKeeper 3.5.5 or greater and
Accumulo 1.9.x or less
+ if StrictVersion(self.version('zookeeper')) >=
StrictVersion("3.5.5") and
StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) <
StrictVersion("1.10.0"):
Review comment:
The issues are minor, possibly a good first issue for someone, so I am
thinking they might get fixed. The zookeeper jar is now in a lib directory, so
start-all.sh and general.classpaths have to be updated. (I am not sure whether
general.classpaths should be updated in Accumulo itself or in Fluo-Muchos, but
at least the ZK jar check in start-all.sh would need to be fixed.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
