keith-turner commented on a change in pull request #328: Added support for Red Hat OS URL: https://github.com/apache/fluo-muchos/pull/328#discussion_r389944705
########## File path: ansible/roles/common/tasks/main.yml ########## @@ -39,6 +52,16 @@ retries: 10 delay: 15 until: yumresult is not failed +- name: "enable SELinux (Red Hat)" + block: + - name: "check if container-selinux is installed" + shell: "rpm -q --quiet container-selinux" + register: container_selinux_installed + failed_when: container_selinux_installed.rc == 2 + - name: "install container-selinux" + shell: "sudo yum -y install http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.107-1.el7_6.noarch.rpm"; Review comment: Could the link use `https` instead of `http`? Also could add a comment like the following. ```suggestion # This makes docker work on RHEL 7 shell: "sudo yum -y install http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.107-1.el7_6.noarch.rpm"; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
