ctubbsii commented on a change in pull request #328: Added support for Red Hat OS URL: https://github.com/apache/fluo-muchos/pull/328#discussion_r390644549
########## File path: ansible/roles/common/tasks/main.yml ########## @@ -39,6 +52,16 @@ retries: 10 delay: 15 until: yumresult is not failed +- name: "enable SELinux (Red Hat)" + block: + - name: "check if container-selinux is installed" + shell: "rpm -q --quiet container-selinux" + register: container_selinux_installed + failed_when: container_selinux_installed.rc == 2 + - name: "install container-selinux" + shell: "sudo yum -y install http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.107-1.el7_6.noarch.rpm"; Review comment: I'm not sure it makes sense to cater to a RHEL AMI without a subscription. Why wouldn't such a user just use a CentOS AMI? It doesn't seem worth the added complexity, and I'm having difficulty imagining that this satisfies a need within the Fluo/Accumulo developer community. As Muchos is not a released product of the Fluo PMC, and is instead an internal tool for testing Fluo/Accumulo themselves, I'm finding it difficult to justify supporting this hybrid RHEL/CentOS approach. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
