karthick-rn commented on a change in pull request #1108:
URL: https://github.com/apache/fluo/pull/1108#discussion_r509903449



##########
File path: contrib/influxdb/fluo_metrics_setup.txt
##########
@@ -13,7 +13,7 @@
 
 # DDL
 CREATE USER fluo WITH PASSWORD 'secret' WITH ALL PRIVILEGES
-CREATE DATABASE IF NOT EXISTS fluo_metrics
+CREATE DATABASE fluo_metrics

Review comment:
       If it exists, the database won't get created and manually running the 
`influx -import` on the metrics host throws the below error. Also, this doesn't 
fail the muchos setup because the import command still produces a return code 
of '0' despite the error. 
   ```bash
   error: error parsing query: found NOT, expected ; at line 1, char 20
   error: database not found: fluo_metrics
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to