karthick-rn commented on a change in pull request #1108:
URL: https://github.com/apache/fluo/pull/1108#discussion_r509937807



##########
File path: contrib/influxdb/fluo_metrics_setup.txt
##########
@@ -13,7 +13,7 @@
 
 # DDL
 CREATE USER fluo WITH PASSWORD 'secret' WITH ALL PRIVILEGES
-CREATE DATABASE IF NOT EXISTS fluo_metrics
+CREATE DATABASE fluo_metrics

Review comment:
       If the database already exists, the rest of the lines still get 
executed. To prove, I did a quick test by manually creating the `fluo_metrics` 
database using the CLI, ran the import script & could see the continuous 
queries show up under `fluo_metrics`. Therefore, I don't see any behavioural 
change. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to