ctubbsii commented on a change in pull request #1113:
URL: https://github.com/apache/fluo/pull/1113#discussion_r595731588
##########
File path:
modules/api/src/main/java/org/apache/fluo/api/client/LoaderExecutor.java
##########
@@ -48,11 +48,12 @@
/**
* Same as {@link #execute(Loader)} except it returns a future that
completes upon successful
- * commit and if an exception is thrown in the loader, it will be relayed
through the future.
+ * commit and if an exception is thrown in the loader, it will be relayed
through the future. The
+ * result of the future is the Loader that was successfully executed.
*
* @since 2.0.0
*/
- CompletableFuture<Void> submit(Loader loader);
+ CompletableFuture<Loader> submit(Loader loader);
Review comment:
I was thinking about how you can't do:
```java
ArrayList<Number> numbers = new ArrayList<Integer>();
```
I always have to do a deep dive every time I refresh my memory on generics
and the use of `super`. I commented above without that refresher and without
trying the suggestions myself. Please use whatever works and disregard the
other suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
