keith-turner commented on a change in pull request #1113:
URL: https://github.com/apache/fluo/pull/1113#discussion_r596967520
##########
File path:
modules/api/src/main/java/org/apache/fluo/api/client/LoaderExecutor.java
##########
@@ -48,11 +48,12 @@
/**
* Same as {@link #execute(Loader)} except it returns a future that
completes upon successful
- * commit and if an exception is thrown in the loader, it will be relayed
through the future.
+ * commit and if an exception is thrown in the loader, it will be relayed
through the future. The
+ * result of the future is the Loader that was successfully executed.
Review comment:
This comment may need to be formatted/wrapped. Trying to communicate
that loaders may execute one or more times.
```suggestion
* result of the future is the Loader that was successfully executed. If
storing any information in the loader object, keep in mind that loaders may
execute multiple times in the case of commit collisions. If a loader executes
multiple times, it may see different data on subsequent executions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
