arvindshmicrosoft commented on a change in pull request #415:
URL: https://github.com/apache/fluo-muchos/pull/415#discussion_r761553470
##########
File path: lib/requirements.txt
##########
@@ -2,3 +2,4 @@ flake8==3.8.0
ansible-core==2.11.3
ansible-lint==5.1.2
nose==1.3.7
+azure==4.0.0
Review comment:
I'm guessing the error is this:
```
Traceback (most recent call last):
File "/home/centos/work/fluo-muchos/lib/main.py", line 22, in <module>
from muchos.config import DeployConfig
File "/home/centos/work/fluo-muchos/lib/muchos/config/__init__.py", line
20, in <module>
from .azure import AzureDeployConfig
File "/home/centos/work/fluo-muchos/lib/muchos/config/azure.py", line 23,
in <module>
from .azurevalidations import validate_azure_configs
File
"/home/centos/work/fluo-muchos/lib/muchos/config/azurevalidations.py", line 24,
in <module>
from azure.mgmt.compute import ComputeManagementClient
ModuleNotFoundError: No module named 'azure'
```
If so, the reason is
[this](https://github.com/apache/fluo-muchos/blob/7decbf3069e592414cfd184b98e424a503c09b6e/lib/muchos/config/__init__.py#L19-L20)
We'll need to think through how to not load the non-required libraries.
Meanwhile, for this PR, my suggestion remains the same - let's not add the
reference to the `azure` library when it is not required (i.e. don't add it in
requirements.txt). I suggest keeping this PR specific to the Hadoop checksum
change, and we can work on the changes / refactoring needed to not require the
azure library, separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
