arvindshmicrosoft commented on a change in pull request #415:
URL: https://github.com/apache/fluo-muchos/pull/415#discussion_r761584620
##########
File path: lib/requirements.txt
##########
@@ -2,3 +2,4 @@ flake8==3.8.0
ansible-core==2.11.3
ansible-lint==5.1.2
nose==1.3.7
+azure==4.0.0
Review comment:
NP - I am including a patch below which will address the "importing"
issue. Feel free to leverage the same in this PR if you like, or LMK if you'd
prefer that I raise another PR with the below changes. In either case, you can
reset your change to requirements.txt.
```
diff --git a/lib/muchos/config/__init__.py b/lib/muchos/config/__init__.py
index 99a88b5..27ba8f4 100644
--- a/lib/muchos/config/__init__.py
+++ b/lib/muchos/config/__init__.py
@@ -15,10 +15,6 @@
# limitations under the License.
#
-from .existing import ExistingDeployConfig
-from .ec2 import Ec2DeployConfig
-from .azure import AzureDeployConfig
-
from configparser import ConfigParser
@@ -35,6 +31,8 @@ def DeployConfig(
cluster_type = c.get("general", "cluster_type")
if cluster_type == "existing":
+ from .existing import ExistingDeployConfig
+
return ExistingDeployConfig(
deploy_path,
config_path,
@@ -45,6 +43,8 @@ def DeployConfig(
)
if cluster_type == "ec2":
+ from .ec2 import Ec2DeployConfig
+
return Ec2DeployConfig(
deploy_path,
config_path,
@@ -55,6 +55,8 @@ def DeployConfig(
)
if cluster_type == "azure":
+ from .azure import AzureDeployConfig
+
return AzureDeployConfig(
deploy_path,
config_path,
diff --git a/lib/tests/azure/test_config.py b/lib/tests/azure/test_config.py
index 69469a3..17ecdc7 100644
--- a/lib/tests/azure/test_config.py
+++ b/lib/tests/azure/test_config.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-from muchos.config import AzureDeployConfig
+from muchos.config.azure import AzureDeployConfig
def test_azure_cluster():
diff --git a/lib/tests/ec2/test_config.py b/lib/tests/ec2/test_config.py
index 58f1afe..4b620ac 100644
--- a/lib/tests/ec2/test_config.py
+++ b/lib/tests/ec2/test_config.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-from muchos.config import Ec2DeployConfig
+from muchos.config.ec2 import Ec2DeployConfig
def test_ec2_cluster():
diff --git a/lib/tests/existing/test_config.py
b/lib/tests/existing/test_config.py
index 1be2a86..4e2f3d6 100644
--- a/lib/tests/existing/test_config.py
+++ b/lib/tests/existing/test_config.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-from muchos.config import ExistingDeployConfig
+from muchos.config.existing import ExistingDeployConfig
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
