ctubbsii commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1014652337
##########
pom.xml:
##########
@@ -308,6 +313,11 @@
<artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
Review Comment:
I think your statements are essentially correct. I'm a bit fuzzy on the
details, having not looked at it in awhile. I think the thrift version property
has something to do with the way the minicluster dependency of
accumulo2-maven-plugin resolves its own transitive dependencies using
Accumulo's pom files, and those pom files use a property to set the version. If
Accumulo had hard-coded the thrift version instead of having a property, it
probably wouldn't be necessary, but it's been too long for me to remember
clearly. I would like to update accumulo2-maven-plugin to work with 2.1 by
default, though. Perhaps we can make improvements to make it easier to avoid
these kinds of frustrations.
As for logging, I don't know what's going on with Hadoop, but ZK 3.8 uses
slf4j 1.7, and defaults to logback. If slf4j 1.7 and logback are excluded as a
transitive dependency, using slf4j2, log4j-slf4j2-impl, and log4j-core should
work well. That's what Accumulo 2.1 uses, and it should work fine with ZK as
well. Fluo currently uses slf4j 1.7 with log4j1, I believe. So, there's a lot
that needs to be updated, including Fluo's log4j config files. I could probably
help out with some of the logging stuff, once basic functionality is working
again with 2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
