ctubbsii commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1014751576
##########
modules/api/pom.xml:
##########
@@ -46,8 +46,8 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
Review Comment:
Yeah, that's the bug. It's supposed to be a runtime dep... it's a runtime
dep for the slf4j 1.7 impl, and it's a runtime dep for the slf4j 1.8 alpha
before it got renamed to slf4j 2.0. Unfortunately, somebody in the log4j
community is thinking a bit *too* modular-ly and decided to make it an optional
dependency, under the idea that somebody mind want want to have the log4j API
bind as the impl to slf4j, but then have some other log4j impl bind to the
log4j API... it's nonsense, of course, because if they wanted to do that,
they'd just bind directly to slf4j. The whole point of the
`log4j-slf4j[2]?-impl` jar is to bind to log4j-core. But, somebody lost sight
of that when they implemented this one, and it hasn't yet been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
