keith-turner commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1015245978
##########
modules/api/pom.xml:
##########
@@ -46,8 +46,8 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j2-impl</artifactId>
Review Comment:
> under the idea that somebody mind want want to have the log4j API bind as
the impl to slf4j, but then have some other log4j impl bind to the log4j API...
it's nonsense,
Interesting, they should wait for that use case to actually materialize and
then make the change rather than make the change based on a hypothetical use
case that will likely never materialize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
