keith-turner commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1015797320
##########
modules/distribution/src/main/config/fluo-env.sh:
##########
@@ -37,7 +37,7 @@ export FLUO_TMP="${FLUO_TMP:-/tmp}"
## Fluo log4j configuration
export FLUO_LOG4J_CONFIG="${FLUO_LOG4J_CONFIG:-${conf}/log4j.properties}"
## Java options along with FLUO_JAVA_OPTS for Fluo command
-JAVA_OPTS=("${FLUO_JAVA_OPTS[@]}"
"-Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}")
+JAVA_OPTS=("${FLUO_JAVA_OPTS[@]}")
Review Comment:
I have no idea why we were setting it. When this property was set to a
non-existent file it caused log4j2 to blow up with some weird error message
with nulls in it. Took me a bit to figure that out. The error message was not
helpful. I need to remove the export a few lines up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
