keith-turner commented on code in PR #1128:
URL: https://github.com/apache/fluo/pull/1128#discussion_r1038521224
##########
modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java:
##########
@@ -132,8 +129,7 @@ private void testRollbackManyImpl(boolean killTransactor)
throws Exception {
if (killTransactor) {
Stamp commitTs = env.getSharedResources().getOracleClient().getStamp();
- exception.expect(FluoException.class);
- tx2.commitPrimaryColumn(cd, commitTs);
+ Assert.assertThrows(FluoException.class, () ->
tx2.commitPrimaryColumn(cd, commitTs));
Review Comment:
Used to this would throw an exception and nothing else in the method would
run. Now the code later in the method will run. I am not sure if that
matters, tomorrow I will look at the test in more depth to see what its doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
