ctubbsii commented on code in PR #1128:
URL: https://github.com/apache/fluo/pull/1128#discussion_r1038607240
##########
modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java:
##########
@@ -132,8 +129,7 @@ private void testRollbackManyImpl(boolean killTransactor)
throws Exception {
if (killTransactor) {
Stamp commitTs = env.getSharedResources().getOracleClient().getStamp();
- exception.expect(FluoException.class);
- tx2.commitPrimaryColumn(cd, commitTs);
+ Assert.assertThrows(FluoException.class, () ->
tx2.commitPrimaryColumn(cd, commitTs));
Review Comment:
If it turns out that we do want to skip the rest, then it should be simple
to do this to keep the same current behavior:
```suggestion
Assert.assertThrows(FluoException.class, () ->
tx2.commitPrimaryColumn(cd, commitTs));
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
