ctubbsii commented on code in PR #307:
URL: https://github.com/apache/fluo-uno/pull/307#discussion_r1884431799
##########
bin/impl/commands.sh:
##########
@@ -165,8 +165,10 @@ function uno_start_main() {
if [[ -z $tmp ]]; then
if [[ $ACCUMULO_VERSION =~ ^1\..*$ ]]; then
"$ACCUMULO_HOME"/bin/start-all.sh
- else
+ elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]*$ ]]; then
Review Comment:
This would match on 2.1.10, but 2.1.4 will have the `--local` flag if my PR
is merged in the main repo to backport it to 2.1.4. So this can just be:
```suggestion
elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]$ ]]; then
```
##########
bin/impl/commands.sh:
##########
@@ -221,8 +223,10 @@ function uno_stop_main() {
if pgrep -f accumulo\\.start >/dev/null; then
if [[ $ACCUMULO_VERSION =~ ^1\..*$ ]]; then
"$ACCUMULO_HOME"/bin/stop-all.sh
- else
+ elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]*$ ]]; then
Review Comment:
```suggestion
elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]$ ]]; then
```
##########
bin/impl/run/accumulo.sh:
##########
@@ -28,7 +28,13 @@ trap 'echo "[ERROR] Error occurred at $BASH_SOURCE:$LINENO
command: $BASH_COMMAN
"$HADOOP_HOME"/bin/hadoop fs -rm -r /accumulo 2>/dev/null || true
"$ACCUMULO_HOME"/bin/accumulo init --clear-instance-name --instance-name
"$ACCUMULO_INSTANCE" --password "$ACCUMULO_PASSWORD"
-"$ACCUMULO_HOME"/bin/accumulo-cluster start
+if [[ $ACCUMULO_VERSION =~ ^1\..*$ ]]; then
+ "$ACCUMULO_HOME"/bin/start-all.sh
+elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]*$ ]]; then
Review Comment:
```suggestion
elif [[ $ACCUMULO_VERSION =~ ^2\.[0-1]\.[0-3]$ ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
