ctubbsii commented on PR #307: URL: https://github.com/apache/fluo-uno/pull/307#issuecomment-2542182986
> > Do you know if you have to handle `-SNAPSHOT` here? It seems like you might. > > That was originally why I had the wildcard at the end of the regex for `[0-3]`. That would have only matched on repetitions of `[0-3]`. If you had an earlier version that had a `[0-3].*`, then I missed it. I doubt we'll reach double digit patch releases, so my correction probably wasn't really important, I suppose. > > However our current SNAPSHOT is 2.1.4-SNAPSHOT which is handled by the else case, so I think we are good. Good point. It's unlikely somebody's going to use uno to test a snapshot of an earlier version. Of course, for the 2.1.4-SNAPSHOT case, it depends on my PR in the main repo getting merged to backport `--local` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
