ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1626876932
That's a lots of **unrelated** changes in a single PR, which will make it very difficult (like slow) to merge. Admittedly, that's also because I have very limited time for FM recently, but that what we have. Given that some of these changes are backward compatible, it would be good the break this up, be done with this set of changes piece by piece. The other thing is, the new Jakarta API can be supported next to the old, so it need not be BC breaking, and things can stay a 2.3.x then. Supporting multiple Java versions was done through the whole history of the project (different java files are compiled with different versions), so that's a not a problem either. Surely it adds some complexity, but also removes the BC obstacle (i.e., if we go for 2.4, there's the logical desire to pack in more changes than supporting Jakarta). `3` and `2.3-gae` source codes are too different for Git merges to work. So features for 2.3 are forward ported manually. 2.3 is not that "far ahead" much. Recreating 3 from 2.4 would be orders of magnitude more work than manually applying your changes on `3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
