kelemen opened a new pull request, #104:
URL: https://github.com/apache/freemarker/pull/104

   Added new generated sources created from `freemarker-javax-servlet` where 
javax references are replaced with jakarta references. Tests are also copied 
(with similar adjustments).
   
   The main remaining question is `freemarker.cache.WebappTemplateLoader`. For 
now, I have left it in the same package renamed to 
`JakartaWebappTemplateLoader`. There are two reasons for this:
   
   - `freemarker.cache` is a split package, and it is awkward to deal with 
this, if we move this class to a new package.
   - This class refers to package private classes and methods from 
`freemarker.cache` (`URLTemplateSource` and `TemplateLoaderUtils`), and making 
them public is an obvious detriment.
   
   That said, I do have a variant of this change where I moved this class into 
another package (in my local copy), so moving to a new package is definitely 
doable, if the used classes (and their methods) are made public.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to