ddekany commented on PR #104: URL: https://github.com/apache/freemarker/pull/104#issuecomment-1872582160
My preference is to copy `freemarker.cache.WebappTemplateLoader` into `freemarker.ext.jakarta.servlet.WebappTemplateLoader`, and make `URLTemplateSource` (and most of its methods) and `TemplateLoaderUtils` public. (These are very old classes, and it's not likely that we will want to change then in an incompatible way, so we might as well let others use them for their own `TemplateLoader`-s.) My reason is exactly to move away from the split-package style. One day the whole javax.serlvet support will be removed, and only jakarta.servlet will remain, and at that point we will delete `freemarker.cache.WebappTemplateLoader`, and then the whole servlet support can be separated without spit-package issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
