I made the changes Darrel requested, removed the overridden logMessage because 
it breaks the contract for that method, and restored the overridden 
isDebugEnabled/isTraceEnabled methods.

Benchmark                                                      Mode  Cnt        
   Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       
1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        
571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        
961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        
493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          
4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          
4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          
5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          
5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       
1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        
554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          
5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          
5434742.791          ops/s

Benchmark                                                                       
        Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat    
       thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat           
       thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat          
       thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams    
       thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams          
       thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                 
       thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams           
       thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                 
       thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat     
       thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat            
       thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat           
       thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams     
       thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams           
       thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                  
       thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams            
       thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                  
       thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat 
       thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams
  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams 
       thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat        
       thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams  
       thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams        
       thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat
   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat   
       thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat  
       thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams
   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams  
       thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat         
       thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams   
       thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams         
       thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat        
       thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat               
       thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat              
       thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams        
       thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams              
       thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                     
       thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams               
       thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                     
       thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat         
       thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                
       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat               
       thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams         
       thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams               
       thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                      
       thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                
       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                      
       thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat     
       thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams
      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams     
       thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat            
       thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams      
       thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams            
       thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat
       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat       
       thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat      
       thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams
       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams      
       thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat             
       thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams       
       thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams             
       thrpt          4124760.341          ops/s


[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for 
[email protected]

Reply via email to