I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger. ``` Old FastLogger (rerun)
Benchmark Mode Cnt Score Error Units FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger thrpt 446697742.457 ops/s FastLoggerBenchmark.debugLambdaLogStatementWithLogger thrpt 565131236.886 ops/s FastLoggerBenchmark.debugLogStatementWithFastLogger thrpt 401641232.494 ops/s FastLoggerBenchmark.debugLogStatementWithLogger thrpt 485306907.748 ops/s FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger thrpt 4326126.623 ops/s FastLoggerBenchmark.infoLambdaLogStatementWithLogger thrpt 4292089.465 ops/s FastLoggerBenchmark.infoLogStatementWithFastLogger thrpt 5763926.454 ops/s FastLoggerBenchmark.infoLogStatementWithLogger thrpt 5310548.197 ops/s FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger thrpt 1699492309.718 ops/s FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger thrpt 569546071.809 ops/s FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger thrpt 5457045.502 ops/s FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger thrpt 5495846.664 ops/s ``` ``` New FastLogger (rerun with updated changes) Benchmark Mode Cnt Score Error Units FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger thrpt 1098409906.287 ops/s FastLoggerBenchmark.debugLambdaLogStatementWithLogger thrpt 571517818.578 ops/s FastLoggerBenchmark.debugLogStatementWithFastLogger thrpt 961929444.019 ops/s FastLoggerBenchmark.debugLogStatementWithLogger thrpt 493419877.521 ops/s FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger thrpt 4880988.472 ops/s FastLoggerBenchmark.infoLambdaLogStatementWithLogger thrpt 4359830.282 ops/s FastLoggerBenchmark.infoLogStatementWithFastLogger thrpt 5871701.712 ops/s FastLoggerBenchmark.infoLogStatementWithLogger thrpt 5413616.788 ops/s FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger thrpt 1614609085.057 ops/s FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger thrpt 554213160.956 ops/s FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger thrpt 5418763.689 ops/s FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger thrpt 5434742.791 ops/s ``` [ Full content available at: https://github.com/apache/geode/pull/2798 ] This message was relayed via gitbox.apache.org for [email protected]
