Why are we using a checked exception here and, thus, manually forcing all callers to handle it even though there's nothing they can do about it?, wouldn't it be better to use an unchecked exception?. Also, is there any scenario under which the `QueryConfigurationService` can be actually `null`?, shouldn't we just default to the `RestrictedMethodAuthorizer` in those cases (providing that security is enabled)?. Also, the exception `ServiceNotFoundException` belongs to the `javax.management` package, since we're not dealing with `JMX` this doesn't seem to be a good fit to be used here (maybe an `IllegalStateException` or similar?).
[ Full content available at: https://github.com/apache/geode/pull/4161 ] This message was relayed via gitbox.apache.org for [email protected]
