agingade commented on a change in pull request #5014:
URL: https://github.com/apache/geode/pull/5014#discussion_r422270326
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
##########
@@ -668,6 +668,8 @@
*/
private int threadMonitorTimeLimit = DEFAULT_THREAD_MONITOR_TIME_LIMIT;
+ private boolean parallelDiskStoreRecovery =
DEFAULT_PARALLEL_DISK_STORE_RECOVERY;
Review comment:
Adding it here, makes it a distribution config setup...For system
property you need to add in "SystemPropertyHelper". Look into
"EVICTION_SCAN_MAX_THREADS" as an example.
Also, tests to verify the system property setting are working as expected....
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java
##########
@@ -141,10 +141,9 @@ DiskStoreImpl createOwnedByRegion(String name, boolean
isOwnedByPR,
@Override
public DiskStore create(String name) {
this.attrs.name = name;
- // As a simple fix for 41290, only allow one DiskStore to be created
- // at a time per cache by syncing on the cache.
DiskStore result;
- synchronized (this.cache) {
+ try {
+ this.cache.lockDiskStore(name);
Review comment:
Does this needs to be before "try"? if lock throws exception without
locking we may be trying to unlock it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
