jchen21 commented on a change in pull request #5014:
URL: https://github.com/apache/geode/pull/5014#discussion_r422289699
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java
##########
@@ -141,10 +141,9 @@ DiskStoreImpl createOwnedByRegion(String name, boolean
isOwnedByPR,
@Override
public DiskStore create(String name) {
this.attrs.name = name;
- // As a simple fix for 41290, only allow one DiskStore to be created
- // at a time per cache by syncing on the cache.
DiskStore result;
- synchronized (this.cache) {
+ try {
+ this.cache.lockDiskStore(name);
Review comment:
The `unlock` in the finally block does nothing, if the `lock` fails. The
`unlock` is essentially a `CountDownLatch.countDown()`. If the current count is
greater than zero then it is decremented. If the current count equals zero then
nothing happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
