[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

[GitBox]

albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011955



##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -709,7 +719,10 @@ public static void 
createPartitionedRegionAsAccessor(String regionName, String s
   }
 
   public static void createPartitionedRegionWithSerialParallelSenderIds(String 
regionName,
-      String serialSenderIds, String parallelSenderIds, String colocatedWith, 
Boolean offHeap) {
+      String serialSenderIds,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -734,7 +747,8 @@ public static void 
createPartitionedRegionWithSerialParallelSenderIds(String reg
   }
 
   public static void createPersistentPartitionedRegion(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+      Integer redundantCopies,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -764,7 +778,9 @@ public static void createPersistentPartitionedRegion(String 
regionName, String s
   }
 
   public static void createCustomerOrderShipmentPartitionedRegion(String 
senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+      Integer redundantCopies,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -830,7 +846,8 @@ public static void 
createCustomerOrderShipmentPartitionedRegion(String senderIds
   }
 
   public static void createColocatedPartitionedRegions(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+      Integer redundantCopies,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -858,7 +875,8 @@ public static void createColocatedPartitionedRegions(String 
regionName, String s
   }
 
   public static void createColocatedPartitionedRegions2(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+      Integer redundantCopies,

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org