[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

[GitBox]

albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011534



##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -519,7 +521,9 @@ public static void 
createReplicatedRegionWithAsyncEventQueue(String regionName,
   }
 
   public static void createReplicatedRegionWithSenderAndAsyncEventQueue(String 
regionName,
-      String senderIds, String asyncChannelId, Boolean offHeap) {
+      String senderIds,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -560,7 +564,8 @@ public static void createReplicatedRegion(String 
regionName, String senderIds, S
   }
 
   public static void createAsyncEventQueue(String asyncChannelId, boolean 
isParallel,
-      Integer maxMemory, Integer batchSize, boolean isConflation, boolean 
isPersistent,
+      Integer maxMemory, Integer batchSize,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -589,7 +594,8 @@ public static void createAsyncEventQueue(String 
asyncChannelId, boolean isParall
   }
 
   public static void createPartitionedRegion(String regionName, String 
senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+      Integer redundantCopies, Integer totalNumBuckets,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -619,7 +625,8 @@ public static void createPartitionedRegion(String 
regionName, String senderIds,
 
   // TODO:OFFHEAP: add offheap flavor
   public static void createPartitionedRegionWithPersistence(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets) {
+      Integer redundantCopies,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -647,7 +654,9 @@ public static void 
createPartitionedRegionWithPersistence(String regionName, Str
   }
 
   public static void createColocatedPartitionedRegion(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets, String colocatedWith) {
+      Integer redundantCopies,

Review comment:
       ok

##########
File path: 
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##########
@@ -691,7 +700,8 @@ public static void 
addAsyncEventQueueThroughAttributesMutator(String regionName,
   }
 
   public static void createPartitionedRegionAsAccessor(String regionName, 
String senderIds,
-      Integer redundantCopies, Integer totalNumBuckets) {
+      Integer redundantCopies,

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org