dschneider-pivotal commented on a change in pull request #5067:
URL: https://github.com/apache/geode/pull/5067#discussion_r425438297
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -437,18 +422,16 @@ private void startGemFire() {
}
@VisibleForTesting
- public RegionProvider getRegionCache() {
- return regionCache;
+ public RegionProvider getRegionProvider() {
Review comment:
Most of the RegionProvider is about managing dynamic regions for lists
and sorted sets. If we would change those data structures to be more like our
RedisSet then I think the RegionProvider might be able to go away. However it
still might make sense to have it to give us the single data region. And it
might be helpful in the future if we have a region per DB.
The work on this branch has more to do with getting rid of the KeyRegistrar.
Once all of our data types are converted over to just use the new DataRegion,
then I think we will find that no code uses the KeyRegistrar methods anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
