[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5067: GEODE-8130: use single region for Sets and Hashes

[GitBox]

dschneider-pivotal commented on a change in pull request #5067:
URL: https://github.com/apache/geode/pull/5067#discussion_r425438654



##########
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -462,37 +445,25 @@ private void initializeRedis() {
         hLLRegion = regionFactory.create(HLL_REGION);
       }
 
-      if ((redisHash = cache.getRegion(HASH_REGION)) == null) {
-        RegionFactory<ByteArrayWrapper, RedisHash> regionFactory =
-            gemFireCache.createRegionFactory(DEFAULT_REGION_TYPE);
-        redisHash = regionFactory.create(HASH_REGION);
-      }
-
-      if ((redisSet = cache.getRegion(SET_REGION)) == null) {
-        RegionFactory<ByteArrayWrapper, RedisSet> regionFactory =
-            gemFireCache.createRegionFactory(DEFAULT_REGION_TYPE);
-        redisSet = regionFactory.create(SET_REGION);
-      }
-
-      if ((redisMetaData = cache.getRegion(REDIS_META_DATA_REGION)) == null) {
-        InternalRegionFactory<String, RedisDataType> redisMetaDataFactory =
-            gemFireCache.createInternalRegionFactory();
+      if ((redisData = cache.getRegion(REDIS_DATA_REGION)) == null) {
+        InternalRegionFactory<ByteArrayWrapper, RedisData> 
redisMetaDataFactory =
+            gemFireCache.createInternalRegionFactory(DEFAULT_REGION_TYPE);
         redisMetaDataFactory.addCacheListener(metaListener);
-        redisMetaDataFactory.setDataPolicy(DataPolicy.REPLICATE);
         
redisMetaDataFactory.setInternalRegion(true).setIsUsedForMetaRegion(true);
-        redisMetaData = redisMetaDataFactory.create(REDIS_META_DATA_REGION);
+        redisData = redisMetaDataFactory.create(REDIS_DATA_REGION);
       }
 
-      keyRegistrar = new KeyRegistrar(redisMetaData);
+      keyRegistrar = new KeyRegistrar(redisData);

Review comment:
       Once all of our data types are converted over to just use the new 
DataRegion, then I think we will find that no code uses the KeyRegistrar 
methods anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org