pivotal-jbarrett commented on a change in pull request #621:
URL: https://github.com/apache/geode-native/pull/621#discussion_r444346251
##########
File path: cppcache/src/SerializationRegistry.hpp
##########
@@ -23,6 +23,7 @@
#include <functional>
#include <iostream>
#include <memory>
+#include <mutex>
Review comment:
You should be able to remove `#include
"util/concurrent/spinlock_mutex.hpp"`
##########
File path: cppcache/src/SerializationRegistry.hpp
##########
@@ -79,10 +80,10 @@ class TheTypeMap {
std::unordered_map<internal::DSFid, TypeFactoryMethod>
m_dataSerializableFixedIdMap;
std::unordered_map<std::string, TypeFactoryMethodPdx> m_pdxSerializableMap;
- mutable util::concurrent::spinlock_mutex m_dataSerializablePrimitiveMapLock;
- mutable util::concurrent::spinlock_mutex m_dataSerializableMapLock;
- mutable util::concurrent::spinlock_mutex m_dataSerializableFixedIdMapLock;
- mutable util::concurrent::spinlock_mutex m_pdxSerializableMapLock;
+ mutable std::mutex m_dataSerializablePrimitiveMapLock;
Review comment:
Given that you are touching 90% of the member variables in this class
perhaps now is a good time to make them style guide compliant and more
correctly named, like `dataSerializableMapMutex_`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
