pivotal-jbarrett commented on a change in pull request #621:
URL: https://github.com/apache/geode-native/pull/621#discussion_r445104329
##########
File path: cppcache/src/SerializationRegistry.hpp
##########
@@ -79,10 +80,10 @@ class TheTypeMap {
std::unordered_map<internal::DSFid, TypeFactoryMethod>
m_dataSerializableFixedIdMap;
std::unordered_map<std::string, TypeFactoryMethodPdx> m_pdxSerializableMap;
- mutable util::concurrent::spinlock_mutex m_dataSerializablePrimitiveMapLock;
- mutable util::concurrent::spinlock_mutex m_dataSerializableMapLock;
- mutable util::concurrent::spinlock_mutex m_dataSerializableFixedIdMapLock;
- mutable util::concurrent::spinlock_mutex m_pdxSerializableMapLock;
+ mutable std::mutex m_dataSerializablePrimitiveMapLock;
Review comment:
Haha. It looks like this guide changed after we adopted it. Camel case
was acceptable at the time. We should probably address this. So I guess do
worry about the variables right now. Thanks for spotting that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
