jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r445141795



##########
File path: 
geode-gfsh/src/main/java/org/apache/geode/management/cli/SingleGfshCommand.java
##########
@@ -39,7 +42,11 @@
    *        return value of your command method.
    * @return a boolean indicating whether a change to the cluster 
configuration was persisted.
    */
-  public boolean updateConfigForGroup(String group, CacheConfig config, Object 
configObject) {
-    return false;
+  public abstract boolean updateConfigForGroup(String group, CacheConfig 
config,
+      Object configObject);
+
+  @Override
+  public boolean affectsClusterConfiguration() {

Review comment:
       It's marked as @Experimental




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to