agingade commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r445867726
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##########
@@ -113,7 +113,7 @@
public class LocatorClusterManagementService implements
ClusterManagementService {
@VisibleForTesting
// the dlock service name used by the CMS
- static final String CMS_DLOCK_SERVICE_NAME = "CMS_DLOCK_SERVICE";
+ public static final String CMS_DLOCK_SERVICE_NAME = "CMS_DLOCK_SERVICE";
Review comment:
My understanding was, we have centralized configuration-management
class, that is used by both gfsh and rest end-point to make the configuration
changes, and I thought it was LocatorClusterManagementService, I guess I am
wrong...
Is it "InternalConfigurationPersistenceService" where both gfsh and
end-point make the configuration changes...If so, can the dlock creation and
unlocking/unlocking helper method be added there.
I am trying to see if we can have the lock creation in one place, rather
than in many clients/apis that make the configuration changes...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
