Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446354173
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##########
@@ -549,7 +550,7 @@ public void setVersionObjectForTest(Version v) {
}
@Override
- public Version getVersionObject() {
+ public VersionOrdinal getVersionObject() {
Review comment:
Since `IDM` isa `MemberIdentifier` this method has to return a
`VersionOrdinal` not a `Version` since, in general, a `MemberIdentifier` can be
for a member that is running an unknown software version.
I'm renaming `MemberIdentifier.getVersionObject()` =>
`MemberIdentifier.getVersionOrdinalObject()` and adding a method
`IDM.getVersionObject()` to really return the version for callers that really
need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
