luissson commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446445811
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/internal/AbstractSerializationContext.java
##########
@@ -25,10 +26,10 @@
*/
public abstract class AbstractSerializationContext {
- <IO> Version getVersionForDataStream(final IO in) {
+ <IO> VersionOrdinal getVersionForDataStream(final IO in) {
// check if this is a versioned data input
if (in instanceof VersionedDataStream) {
- final Version v = ((VersionedDataStream) in).getVersion();
+ final VersionOrdinal v = ((VersionedDataStream) in).getVersion();
return v != null ? v : Version.getCurrentVersion();
Review comment:
the return here may be either Version or VersionOrdinal, do we want to
upcast or downcast to ensure returning a single type? Doesn't appear to be a
problem currently though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
