Bill commented on a change in pull request #5334:
URL: https://github.com/apache/geode/pull/5334#discussion_r448569055
##########
File path:
geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
##########
@@ -205,6 +210,22 @@ void doTestRollAll(String regionType, String objectType,
String startingVersion)
verifyValues(objectType, regionName, 0, 10, server2);
putAndVerify(objectType, server2, regionName, 15, 25, server1);
+ final short versionOrdinalAfterUpgrade =
Version.getCurrentVersion().ordinal();
+ locator.invoke(() -> {
+
+ final Locator theLocator = Locator.getLocator();
+ final DistributedSystem distributedSystem =
theLocator.getDistributedSystem();
+ final InternalDistributedSystem ids =
+ (InternalDistributedSystem) distributedSystem;
+ final DistributionManager distributionManager =
ids.getDistributionManager();
+ final MembershipView<InternalDistributedMember> view =
+ distributionManager.getDistribution().getView();
+
+ for (final InternalDistributedMember member : view.getMembers()) {
+
assertThat(member.getVersionOrdinal()).isEqualTo(versionOrdinalAfterUpgrade);
+ }
+ });
Review comment:
This is the new rolling upgrade test logic that verifies that after the
upgrade, all the `MemberIdentifiers` in the view, report the current version
(not an old version.)
This is adapted from the original Ericsson PR that showed us the bug that
became GEODE-8240. Rather than use gfsh, we are delving into the `IDM` directly
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
