Bill commented on pull request #5334:
URL: https://github.com/apache/geode/pull/5334#issuecomment-652679430
> I don't think InternalDistributedMember should be changed in order to make
this new unit test pass. Instead, the unit test should be changed to use
MemberIdentifierImplFactory and MemberIdentifierImpl. That's what the test is
doing in the develop branch. That was done a while ago & it just didn't make it
over to the support branch.
Right you are! I undid my change to `IDM.equals(other)` in favor of small
changes to `GMSJoinLeaveJUnitTest`.
Good advice!
> Also, shouldn't this be ported to support/1.13 before it's ported to
support/1.12?
Ooh yeah. I'll go do that…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
