bschuchardt commented on a change in pull request #5363:
URL: https://github.com/apache/geode/pull/5363#discussion_r454643105
##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/NioFilter.java
##########
@@ -53,7 +53,7 @@ ByteBuffer ensureWrappedCapacity(int amount, ByteBuffer
wrappedBuffer,
* wrappedBuffer = filter.ensureWrappedCapacity(amount, wrappedBuffer,
etc.);<br>
* unwrappedBuffer = filter.readAtLeast(channel, amount, wrappedBuffer, etc.)
*/
- ByteBuffer readAtLeast(SocketChannel channel, int amount, ByteBuffer
wrappedBuffer)
+ ByteBuffer readAtLeast(int amount, ByteBuffer wrappedBuffer, Socket socket)
Review comment:
on second thought, I'm going to undo those changes. My first cut at a
solution modified the filters to allow their use with an SSLSocket and its
input stream, but I decided that it was better to stop using them at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
