Bill commented on a change in pull request #5363:
URL: https://github.com/apache/geode/pull/5363#discussion_r454742632
##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/NioFilter.java
##########
@@ -53,7 +53,7 @@ ByteBuffer ensureWrappedCapacity(int amount, ByteBuffer
wrappedBuffer,
* wrappedBuffer = filter.ensureWrappedCapacity(amount, wrappedBuffer,
etc.);<br>
* unwrappedBuffer = filter.readAtLeast(channel, amount, wrappedBuffer, etc.)
*/
- ByteBuffer readAtLeast(SocketChannel channel, int amount, ByteBuffer
wrappedBuffer)
+ ByteBuffer readAtLeast(int amount, ByteBuffer wrappedBuffer, Socket socket)
Review comment:
ah I failed to understand that both these things are true at once:
"This PR … removes the use of "new IO" SSLEngine as an option."
and
"There are a few changes to the NIO "engine" implementations that I made
while testing performance that I decided to keep because they allow the
use of NioPlainEngine with SSLSockets. That could be an advantage when
performing similar work in client/server communications"
If I understand: implication of the second bit is that we didn't remove
SSLEngine from the codebase—we only eliminated it in the P2P messaging path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
