bschuchardt commented on a change in pull request #5363:
URL: https://github.com/apache/geode/pull/5363#discussion_r456523975
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/net/SocketUtils.java
##########
@@ -89,6 +89,10 @@ public static boolean close(final ServerSocket serverSocket)
{
* and buffer.remaining is also zero the limit is changed to be
buffer.capacity
* before reading.
*
+ * @param socket the socket to read from
+ * @param inputBuffer the buffer into which data should be stored
+ * @param socketInputStream the socket's inputStream, included as a
parameter so it can be a
+ * buffered stream, if desired
Review comment:
The older Old IO code base used a BufferedInputStream wrapper around the
socket's input stream on recommendation from StackOverflow and other sources.
I did not find that it increased performance so I removed that wrapper, but I
left this parameter in place for flexibility since this is a "Util" class.
This parameter also makes the methods easier to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
