gaussianrecurrence commented on pull request #680: URL: https://github.com/apache/geode-native/pull/680#issuecomment-718257918
> I am running an [ABI compliance tool](https://lvc.github.io/abi-compliance-checker/) having compiled both the develop branch and the PR's branch and oddly it states that changes introduced are ABI backward compatible. I will try to run the same check with Clang-6.0 and onwards so as well as with MSVC. > > As stated by @pivotal-jbarrett, exposing base class destructors into vtable should be an ABI breaking change. For some reason in both GCC/Clang seems to have no impact. I've opened an [stackoverflow question](https://stackoverflow.com/questions/64576696/exposing-a-base-class-destructor-as-virtual-means-breaking-abi-backward-compatib) just to clarify it, but in the case of MSVC it does. For example for the case of CqQuery vtable is shifted by one position... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
