pivotal-jbarrett commented on pull request #680: URL: https://github.com/apache/geode-native/pull/680#issuecomment-718848764
> Also, another tangential question, why are we saying ABI breakage requires a major version change? Might be worth writing that down somewhere (unless it is already in the wiki, which I never check). Assuming because it requires consumers of geode native to recompile, but are there other reasons? This is a semantic versioning thing. An ABI breaking change would require a recompilation of the downstream application. Normally I can drop a minor updated dependency library in place and just restart the downstream application, no recompilation required. An ABI change requires a recompilation, even if the API is unchanged, because the behavior will now be unknown between the downstream application and the library. In this particular case which side of the library boundary generated the destructor and is it in a VTable or not. It is possible that the compiler did the right thing, in seeing that there were virtual methods on class it behind the scenes produced a virtual destructor and exported it as such in the ABI. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
