sabbey37 commented on a change in pull request #5732:
URL: https://github.com/apache/geode/pull/5732#discussion_r521637229
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -49,8 +51,8 @@ failCount=0
--redis-port=6379 \
--redis-bind-address=127.0.0.1
-./runtest --host 127.0.0.1 --port 6379 --single unit/type/set --single
unit/expire \
---single unit/type/hash --single unit/type/string --single
unit/type/srandmember \
+./runtest --host 127.0.0.1 --port 6380 --single unit/type/set --single
unit/expire \
Review comment:
We should change this back to 6379
##########
File path:
geode-redis/src/commonTest/java/org/apache/geode/redis/GeodeRedisServerRule.java
##########
@@ -43,7 +43,7 @@ public GeodeRedisServerRule() {
@Override
protected void before() {
cache = cacheFactory.create();
- server = new GeodeRedisServer("localhost", 0, (InternalCache) cache);
+ server = new GeodeRedisServer("localhost", 6380, (InternalCache) cache);
Review comment:
Change this back to `0`
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/GeodeServerRunTest.java
##########
@@ -29,7 +28,8 @@
public static GeodeRedisServerRule server = new GeodeRedisServerRule();
@Test
- @Ignore("This is a no-op test to conveniently run redis api for geode server
for local development/testing purposes")
Review comment:
This should be ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
