sabbey37 commented on a change in pull request #5732: URL: https://github.com/apache/geode/pull/5732#discussion_r521640333
########## File path: ci/scripts/execute_redis_tests.sh ########## @@ -19,12 +19,14 @@ cd .. -# We are currently using a personal fork for this repo because our code does not implement all +# We are currently using a patched version of this repo because our code does not implement all # Redis commands. Once all commands needed to run relevant test files are implemented, we hope to -# use Redis's repo instead. -git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +# use Redis's repo without a patch. +git clone --config transfer.fsckObjects=false https://github.com/redis/redis.git +cp geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch redis cd redis git checkout tests-geode-redis Review comment: Correct me if I'm missing something, but I don't think the `tests-geode-redis` branch is in the `redis` repo. I guess we could check out the `5.0` branch. Have you tried this sequence locally with a fresh clone of the `redis` repo that doesn't have any local branches/branches from other forks? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
