nabarunnag commented on a change in pull request #5770:
URL: https://github.com/apache/geode/pull/5770#discussion_r532776796
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
##########
@@ -111,10 +111,9 @@ public
SerialGatewaySenderEventProcessor(AbstractGatewaySender sender, String id
ThreadsMonitoring tMonitoring, boolean cleanQueues) {
super("Event Processor for GatewaySender_" + id, sender, tMonitoring);
+ initializeMessageQueue(id, cleanQueues);
Review comment:
This change is because the CacheListener to handle the
unprocessedEventsMap is set here, hence I wanted the listener to be up and
running before the map is initialized so the no events are missed because they
were put in the map before the listener was running.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
##########
@@ -111,10 +111,9 @@ public
SerialGatewaySenderEventProcessor(AbstractGatewaySender sender, String id
ThreadsMonitoring tMonitoring, boolean cleanQueues) {
super("Event Processor for GatewaySender_" + id, sender, tMonitoring);
+ initializeMessageQueue(id, cleanQueues);
Review comment:
This change is because the CacheListener to handle the
unprocessedEventsMap is set here, hence I wanted the listener to be up and
running before the map is initialized so that no events are missed because they
were put in the map before the listener was running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
