DonalEvans commented on a change in pull request #5770:
URL: https://github.com/apache/geode/pull/5770#discussion_r532787287
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPersistenceEnabledGatewaySenderDUnitTest.java
##########
@@ -603,27 +605,32 @@ public void
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueue
vm7.invoke(() ->
WANTestBase.createPersistentReplicatedRegion(getTestMethodName() + "_RR", "ln",
isOffHeap()));
+ vm4.invoke(() -> WANTestBase.pauseSender("ln"));
+ vm5.invoke(() -> WANTestBase.pauseSender("ln"));
+
vm4.invoke(() -> WANTestBase.doPuts(getTestMethodName() + "_RR", 1000));
logger.info("Completed puts in the region");
vm4.invoke(() -> WANTestBase.stopSender("ln"));
vm5.invoke(() -> WANTestBase.stopSender("ln"));
- logger.info("Stopped all the senders. ");
- // Create receiver on remote site
- createReceiverInVMs(vm2, vm3);
+ logger.info("Stopped all the senders. ");
Review comment:
Instead of using the logger in this test to track progress, you could
instead use the `invoke()` method signature that passes a String
description/name as the first parameter, which allows anyone debugging the test
to see when the invocation in question starts and finishes. Just personal
preference, but I think it makes things neater and provides a little more
information to anyone looking at the test output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
