pdxcodemonkey commented on pull request #697:
URL: https://github.com/apache/geode-native/pull/697#issuecomment-744595577
Well I guess we know why Connector needs to be APACHE_GEODE_EXPORT now:
```
c:\nativeclient\cppcache\src\TcpConn.hpp(33): error C2220: warning treated
as error - no 'object' file generated (compiling source file
C:\nativeclient\cppcache\src\TcpConn.cpp)
[C:\build\cppcache\shared\apache-geode.vcxproj]
c:\nativeclient\cppcache\src\TcpConn.hpp(33): warning C4275: non
dll-interface class 'apache::geode::client::Connector' used as base for
dll-interface class 'apache::geode::client::TcpConn' (compiling source file
C:\nativeclient\cppcache\src\TcpConn.cpp)
[C:\build\cppcache\shared\apache-geode.vcxproj]
c:\nativeclient\cppcache\src\Connector.hpp(40): note: see declaration of
'apache::geode::client::Connector' (compiling source file
C:\nativeclient\cppcache\src\TcpConn.cpp)
c:\nativeclient\cppcache\src\TcpConn.hpp(33): note: see declaration of
'apache::geode::client::TcpConn' (compiling source file
C:\nativeclient\cppcache\src\TcpConn.cpp)
c:\nativeclient\cppcache\src\TcpConn.hpp(33): error C2220: warning treated
as error - no 'object' file generated (compiling source file
C:\nativeclient\cppcache\src\TcpSslConn.cpp)
[C:\build\cppcache\shared\apache-geode.vcxproj]
c:\nativeclient\cppcache\src\TcpConn.hpp(33): warning C4275: non
dll-interface class 'apache::geode::client::Connector' used as base for
dll-interface class 'apache::geode::client::TcpConn' (compiling source file
C:\nativeclient\cppcache\src\TcpSslConn.cpp)
[C:\build\cppcache\shared\apache-geode.vcxproj]
c:\nativeclient\cppcache\src\Connector.hpp(40): note: see declaration of
'apache::geode::client::Connector' (compiling source file C:\nativeclient\
```
It looks like TcpConn has also been exported and wasn't before. Perhaps
fixing that will take care of everything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
